Support hex digits in character classes and escaped characters in character class ranges #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <[email protected]>
Signed-off-by: Anthony Chang <[email protected]>
- fails some fuzz tests Signed-off-by: Anthony Chang <[email protected]>
…into support-hex-character-class Signed-off-by: Anthony Chang <[email protected]>
…heir character representation Signed-off-by: Anthony Chang <[email protected]>
…into support-hex-character-class
Signed-off-by: Anthony Chang <[email protected]>
Signed-off-by: Anthony Chang <[email protected]>
|
build |
andygrove
reviewed
May 25, 2022
andygrove
reviewed
May 25, 2022
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Show resolved
Hide resolved
andygrove
previously approved these changes
May 25, 2022
Signed-off-by: Anthony Chang <[email protected]>
|
build |
andygrove
previously approved these changes
May 25, 2022
…into support-hex-character-class Signed-off-by: Anthony Chang <[email protected]>
|
build |
andygrove
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4865, fixes #4505, closes #4518
This PR allows hexadecimal digits to be used in character classes and ranges in character classes. To support this, I have also generalized this to support all valid escaped characters in character class ranges.
A few notes:
\, ^, -, ], +. These are the characters that may be escaped in a character class\n, \r, \t, \f, \a, \b, \eas all the literals that use a backslash (https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html under "Characters")\x5einstead of^), Java treats this as an escaped metacharacter. Because of this, we cannot directly transpile hex digits to their unicode representation--we need to first check if it is a metacharacter.Example:
[\x5ea]should transpile to[\^a]Signed-off-by: Anthony Chang [email protected]