-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle ?
, *
, {0,}
and {0,n}
based repetitions in regexp_replace on the GPU
#5450
Handle ?
, *
, {0,}
and {0,n}
based repetitions in regexp_replace on the GPU
#5450
Conversation
Signed-off-by: Navin Kumar <[email protected]>
Signed-off-by: Navin Kumar <[email protected]>
…ar_qmark_regexp_replace
Signed-off-by: Navin Kumar <[email protected]>
build |
Signed-off-by: Navin Kumar <[email protected]>
build |
I am working on debugging the test that fails in CI but not locally |
build |
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Outdated
Show resolved
Hide resolved
…TranspilerSuite.scala
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build |
There are new failures since upmerging.
|
@NVnavkumar could you retarget this for 22.08 |
…ar_qmark_regexp_replace
…o star_qmark_regexp_replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Navin Kumar <[email protected]>
build |
…ar_qmark_regexp_replace
build |
1 similar comment
build |
build |
…ar_qmark_regexp_replace
build |
Fixes #4468.
This enables "zero-or-more"-based repetitions in regexp_replace operations that would run the GPU. This was possible due to rapidsai/cudf#10760 being merged and fixing a crash scenario that originally was occurring with these types of repetitions and input that fully matches the regexp.