Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to GpuUnion operator #543

Merged
merged 6 commits into from
Aug 13, 2020
Merged

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Aug 11, 2020

This fixes #508 .
We see correct metrics for GpuUnion now.

@nartal1 nartal1 requested a review from revans2 August 11, 2020 02:48
@nartal1 nartal1 self-assigned this Aug 11, 2020
@nartal1 nartal1 added this to the Aug 3 - Aug 14 milestone Aug 11, 2020
@nartal1
Copy link
Collaborator Author

nartal1 commented Aug 11, 2020

@revans2 Could you please take a look. For GpuUnion, we are directly calling executeColumnar for each RDD. So to get the metrics, I split it as above.

Signed-off-by: Niranjan Artal <[email protected]>
Signed-off-by: Niranjan Artal <[email protected]>
@revans2
Copy link
Collaborator

revans2 commented Aug 12, 2020

build

@nartal1 nartal1 merged commit ae4b00d into NVIDIA:branch-0.2 Aug 13, 2020
@sameerz sameerz added the feature request New feature or request label Aug 14, 2020
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Add metrics to GpuUnion operator

* minor fix

* fix imports

* addressed review comments

Signed-off-by: Niranjan Artal <[email protected]>

* add line

Signed-off-by: Niranjan Artal <[email protected]>
nartal1 added a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Add metrics to GpuUnion operator

* minor fix

* fix imports

* addressed review comments

Signed-off-by: Niranjan Artal <[email protected]>

* add line

Signed-off-by: Niranjan Artal <[email protected]>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#543)

Signed-off-by: spark-rapids automation <[email protected]>

Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GpuUnion publishes metrics on the UI that are all 0
3 participants