Qualification tool: Skip GPU event logs #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
tgravescs
reviewed
Apr 28, 2022
tools/src/test/scala/com/nvidia/spark/rapids/tool/qualification/QualificationSuite.scala
Outdated
Show resolved
Hide resolved
tools/src/test/scala/com/nvidia/spark/rapids/tool/qualification/QualificationSuite.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Apr 28, 2022
.../main/scala/org/apache/spark/sql/rapids/tool/qualification/QualificationEventProcessor.scala
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
tgravescs
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5269. Qualification tool is used to qualify if the applications are good candidates to run on GPU by processing CPU event logs. So this PR skips the processing event logs which are run on GPU.
Added test and updated current tests which were reading GPU event logs.