Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling tool: Remove gettingResultTime from stages & jobs aggregation #5202

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Apr 11, 2022

This fixes #5099

As mentioned in the issue, gettingResultTime from TaskInfo is The time when the task started remotely getting the result which is not a value can be summed. Removed it from JobStageAggTaskMetricsProfileResult and SQLTaskAggMetricsProfileResult case classes and updated the docs and test results.

@nartal1 nartal1 added bug Something isn't working tools labels Apr 11, 2022
@nartal1 nartal1 added this to the Apr 4 - Apr 15 milestone Apr 11, 2022
@nartal1 nartal1 requested a review from tgravescs April 11, 2022 23:59
@nartal1 nartal1 self-assigned this Apr 11, 2022
@nartal1
Copy link
Collaborator Author

nartal1 commented Apr 11, 2022

build

@tgravescs
Copy link
Collaborator

markdown failure is just 22.04 jar link that isn't published yet.

@tgravescs tgravescs merged commit 5f8c3dc into NVIDIA:branch-22.06 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Profiling tool should not sum gettingResultTime
2 participants