Add in basic support for running tpcds like queries #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
abellina
requested changes
Aug 4, 2020
integration_tests/src/main/scala/com/nvidia/spark/rapids/tests/tpcds/TpcdsLikeBench.scala
Outdated
Show resolved
Hide resolved
abellina
reviewed
Aug 4, 2020
integration_tests/src/main/scala/com/nvidia/spark/rapids/tests/tpcds/TpcdsLikeSpark.scala
Show resolved
Hide resolved
jlowe
reviewed
Aug 4, 2020
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
@abellina please take another look |
jlowe
previously approved these changes
Aug 4, 2020
abellina
previously approved these changes
Aug 4, 2020
|
can we document the restrictions and diffs like you have in the description in the code for reference. |
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
@tgravescs please take another look |
tgravescs
approved these changes
Aug 4, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in several TPC-DS like queries into the integration tests. They are based off of the databricks version at https://github.com/databricks/spark-sql-perf but I modified a few of the queries slightly so that our test code could sort the results properly to verify that the correctness of the results.
I have tested this on data at a scale factor of 1 and everything passes, but not everything is running on the GPU.
I disabled partitioning of the data when writing parquet for now, just because it produced really really small files, and we might need to look into what is the right thing to do for larger test runs.
I plan on doing some more testing at la larger scale factor to see how things go.
There are here mostly to help us debug issue with customers who are running tpc-ds. These are not official runs in any way.