Fix Spark 3.1.0 build for HashJoin changes #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <[email protected]>
|
build |
kuhushukla
previously approved these changes
Jul 31, 2020
tgravescs
commented
Jul 31, 2020
shims/spark310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/GpuHashJoin.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Graves <[email protected]>
|
build |
revans2
approved these changes
Jul 31, 2020
jlowe
approved these changes
Jul 31, 2020
|
failures are due to other AQE changes from SPARK-32332 |
|
I'm going to merge this so we fix this issue and then AQE tests can be disabled in another PR |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix Spark 3.1.0 build for HashJoin changes Signed-off-by: Thomas Graves <[email protected]> * Fix missing space Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Fix Spark 3.1.0 build for HashJoin changes Signed-off-by: Thomas Graves <[email protected]> * Fix missing space Signed-off-by: Thomas Graves <[email protected]> Co-authored-by: Thomas Graves <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Peixin Li <[email protected]> Signed-off-by: Peixin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark 3.1.0 committed a change (apache/spark@ae82768) to add codegen to ShuffledHashJoin. This moved the CodegenSupport to be in the base HashJoin which we inherit from and requires a couple more api's to be implemented.
This PR is simply to fix the build because more changes will be required to make it functionally correct so that we don't try to do CodeGen with GpuShuffledHashJoin. Follow up issue for that is: #489
Signed-off-by: Thomas Graves [email protected]