Avoid regexp_cost with stringSplit on the GPU using transpilation #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranspiling escaped meta characters and plain characters into a simpler string Signed-off-by: Navin Kumar <[email protected]>
andygrove
reviewed
Feb 24, 2022
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Feb 24, 2022
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Feb 24, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Navin Kumar <[email protected]>
…leToSplittableString checks are similar Signed-off-by: Navin Kumar <[email protected]>
revans2
approved these changes
Feb 24, 2022
| @@ -277,7 +277,7 @@ class RegexParser(pattern: String) { | |||
| // word boundaries | |||
| consumeExpected(ch) | |||
| RegexEscaped(ch) | |||
| case '[' | '\\' | '^' | '$' | '.' | '⎮' | '?' | '*' | '+' | '(' | ')' | '{' | '}' => | |||
| case '[' | '\\' | '^' | '$' | '.' | '|' | '?' | '*' | '+' | '(' | ')' | '{' | '}' => | |||
There was a problem hiding this comment.
The pipe char changed? What was it before and was that a bug?
There was a problem hiding this comment.
It was some accidental unicode version (https://www.compart.com/en/unicode/U+23AE)
|
build |
andygrove
approved these changes
Feb 24, 2022
|
It looks like there was a transient build failure |
|
build |
1 similar comment
|
build |
|
The vulnerability scan is failing with |
|
build |
2 similar comments
|
build |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4685.
This avoids the RegExp cost on the GPU by transpiling simple patterns that only contain a combination of non-special characters and escaped meta characters to simplified strings that can be passed to string split with RegExp disabled.
Signed-off-by: Navin Kumar [email protected]