Reduce redundancy of decimal testing [databricks] #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
build |
revans2
previously approved these changes
Feb 18, 2022
|
The cache failures on Databricks 9.1 were because the cache tests (which only run on Spark 3.1+) failed on the added DECIMAL128 inputs. Filed #4826 and excluded those from the cache test types. |
|
build |
|
Note that this PR appears to reduce the overall python tests count during premerge by about 2000 tests, from 16550 down to 14494. |
revans2
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4538
Reduces the number of decimal types being tested for most tests that aren't really focused on decimal semantics. Now most tests that test across types will test only three decimal combinations, a 32-bit decimal, a 64-bit decimal, and a 128-bit decimal. In addition the following notable changes were made:
decimal_gensnow includes 128-bit decimals.all_gennow includes 128-bit decimals