Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize DECIMAL128 sum aggregations [databricks] #4688

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Optimize DECIMAL128 sum aggregations [databricks] #4688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29d2b6f
Optimize DECIMAL128 sum aggregations
jlowe Jan 27, 2022
423da9b
Fix regression in window sum
jlowe Feb 4, 2022
498373e
Update for review comments
jlowe Feb 7, 2022
93245c8
Explicitly upcast input to avoid libcudf sort-based aggregation issue
jlowe Feb 8, 2022
60593fb
Lower batch limit in agg tests to better exercise sort-based aggregat…
jlowe Feb 8, 2022
364fd58
Merge branch 'branch-22.04' into dec128-agg-perf
jlowe Feb 8, 2022
bf22a3c
Remove redundant method override
jlowe Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration_tests/src/main/python/hash_aggregate_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}

_no_nans_float_smallbatch_conf = copy_and_update(_no_nans_float_conf,
{'spark.rapids.sql.batchSizeBytes' : '1000'})
{'spark.rapids.sql.batchSizeBytes' : '250'})

_no_nans_float_conf_partial = copy_and_update(_no_nans_float_conf,
{'spark.rapids.sql.hashAgg.replaceMode': 'partial'})
Expand Down Expand Up @@ -339,7 +339,7 @@ def test_hash_reduction_sum_count_action(data_gen):
# Make sure that we can do computation in the group by columns
@ignore_order
def test_computation_in_grpby_columns():
conf = {'spark.rapids.sql.batchSizeBytes' : '1000'}
conf = {'spark.rapids.sql.batchSizeBytes' : '250'}
data_gen = [
('a', RepeatSeqGen(StringGen('a{1,20}'), length=50)),
('b', short_gen)]
Expand Down
Loading