Temporarily disable integration test - test_hash_reduction_pivot_without_nans #4534
Conversation
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
| .pivot('b') | ||
| .agg(f.sum('c')), | ||
| conf=conf) | ||
| # https://github.com/NVIDIA/spark-rapids/issues/4514 |
There was a problem hiding this comment.
It would be better to skip the test rather than comment it out:
@pytest.mark.skip(reason='https://github.com/NVIDIA/spark-rapids/issues/4514')
There was a problem hiding this comment.
xfail seems appropriate here, as this is code we fully expect to pass but is failing due to known issues. skip should be used for tests that are never expected to pass if attempted, even after bugfixes (e.g.: tests for a feature that a particular Spark version does not support, etc.)
There was a problem hiding this comment.
It doesn't seem to be failing in github CI, so we probably want to skip?
There was a problem hiding this comment.
xfail is what we want. xfail is fine if the test actually passes (it reports it as an XPASS result).
There was a problem hiding this comment.
ah ok, sorry I thought xfail actually failed the tests when it passed. Thanks
There was a problem hiding this comment.
There is a config for that I wish we had done a good enough job with things that it would fail. But that is not how it is right now :(
Signed-off-by: Niranjan Artal <[email protected]>
Signed-off-by: Niranjan Artal <[email protected]>
|
Thanks for the review. I have changed the test to xfail. PTAL. |
|
build |
…vot_without_nans (NVIDIA#4534)" This reverts commit 7d8b6d4. Signed-off-by: Jason Lowe <[email protected]>
…vot_without_nans (#4534)" (#4553) This reverts commit 7d8b6d4. Signed-off-by: Jason Lowe <[email protected]>
This PR is to temporarily disable test_hash_reduction_pivot_without_nans test until we have a proper fix for the issue
#4514.
I am not able to repro the issue in YARN cluster so it might take sometime to reproduce and fix the bug.
This would help the CI pipelines to be green.