Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce NoScalaDoc rule in scalastyle checks #449

Merged
merged 8 commits into from
Jul 28, 2020
Merged

Enforce NoScalaDoc rule in scalastyle checks #449

merged 8 commits into from
Jul 28, 2020

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Jul 28, 2020 •
edited
Loading

This implements the same NoScalaDoc rule that Spark uses, to enforce JavaDoc-style indenting of block comments.

This closes #184

@andygrove andygrove added this to the Jul 20 - Jul 31 milestone Jul 28, 2020
@andygrove andygrove added the build Related to CI / CD or cleanly building label Jul 28, 2020
@andygrove
Copy link
Contributor Author

build

jlowe
jlowe previously approved these changes Jul 28, 2020
View reviewed changes
revans2
revans2 previously approved these changes Jul 28, 2020
View reviewed changes
@jlowe
Copy link
Member

jlowe commented Jul 28, 2020

Looks like a couple of things left to fix:

13:51:00  error file=/ansible-managed/jenkins-slave/slave3/workspace/spark/rapids_premerge-github/tests/src/test/scala/com/nvidia/spark/rapids/CsvScanSuite.scala message=Use Javadoc style indentation for multiline comments line=49 column=0
13:51:00  error file=/ansible-managed/jenkins-slave/slave3/workspace/spark/rapids_premerge-github/tests/src/test/scala/com/nvidia/spark/rapids/SparkQueryCompareTestSuite.scala message=Use Javadoc style indentation for multiline comments line=296 column=0

@andygrove andygrove dismissed stale reviews from revans2 and jlowe via 89078bd July 28, 2020 19:55
@andygrove
Copy link
Contributor Author

build

@jlowe jlowe merged commit b3c46b4 into NVIDIA:branch-0.2 Jul 28, 2020
@jlowe jlowe mentioned this pull request Jul 29, 2020
Merged
@andygrove andygrove deleted the no-scaladoc branch August 14, 2020 18:16
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@andygrove
Enforce NoScalaDoc rule in scalastyle checks (NVIDIA#449)
9f947b7 
* fix rule

* fix violations

* fix violations

* fix violations

* remove comment

* re-order rules, add comment back

* fix violations in tests module
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@andygrove
Enforce NoScalaDoc rule in scalastyle checks (NVIDIA#449)
899a091 
* fix rule

* fix violations

* fix violations

* fix violations

* remove comment

* re-order rules, add comment back

* fix violations in tests module
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
@nvkevlu
fix issue of admin API not having poc_key in poc mode (NVIDIA#449)
9571667 
* fix issue of admin API not having poc_key in poc mode

* fix issue with poc mode using username and poc_key, move to inside AdminAPI
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to dcae9f7 (NVIDIA#449)
f734971 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 revans2 left review comments

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Jul 20 - Jul 31
Development

Successfully merging this pull request may close these issues.

[FEA] Enable NoScalaDoc scalastyle rule
3 participants
@andygrove @jlowe @revans2