Preliminary support for keeping broadcast exchanges on GPU when AQE is enabled #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
|
build |
|
notes this is going to conflict with #442 as well |
|
build |
revans2
approved these changes
Jul 30, 2020
| extensions: SparkSessionExtensions, | ||
| ruleBuilder: SparkSession => Rule[SparkPlan]): Unit = { | ||
| // not supported in 3.0.0 but it doesn't matter because AdaptiveSparkPlanExec in 3.0.0 will | ||
| // never allow us to replace an Exchange node, so they just stay on CPU |
There was a problem hiding this comment.
Should we throw an exception here to be sure of that assumption?
There was a problem hiding this comment.
Well, this code will still be called when we run with 3.0.0 but we can't inject the rule, because that feature isn't available in 3.0.0.
When the plugin runs against 3.0.0 with AQE on, our optimizer rules will only get applied to the children of any exchange nodes.
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for injecting a query stage preparation rule for Spark versions 3.0.1 and 3.1.0 to tag the SparkPlan with any reasons that operators cannot be supported on the GPU. It also updates the GpuOverrides checks for BroadcastExchangeExec to check for any tagged reasons when new query stages are created (when AQE is enabled).
Note that these changes won't have any effect on functionality yet but will be leveraged once SPARK-32332 is merged.
The TPCH integration tests run with AQE on and off and cover test cases that test this new code path.