Move casting to string tests from array_test.py and struct_test.py to cast_test.py #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <[email protected]>
remove timestamp from not-matched type refactor the code Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
|
build |
optimize the data_gen of cast_struct_to_string Signed-off-by: remzi <[email protected]>
|
build |
revans2
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi [email protected]
close #4262
Move the casting to string tests of array and struct to the file cast_test.py, because most of the casting tests are in this file.
Also, we refactor the code so that it is easier to be updated when adding new element types.
Besides, as it is supported to cast Timestamp to string, we update the corresponding code.