Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for timestamps that overflowed before. #4274

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Dec 2, 2021

This closes #4205

It was actually fixed by rapidsai/cudf#9793 but this adds in tests from the original bug.

@revans2 revans2 added the test Only impacts tests label Dec 2, 2021
@revans2 revans2 added this to the Nov 30 - Dec 10 milestone Dec 2, 2021
@revans2 revans2 self-assigned this Dec 2, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Dec 2, 2021

build

@revans2 revans2 merged commit 8324b70 into NVIDIA:branch-22.02 Dec 3, 2021
@revans2 revans2 deleted the timestamp_to_str_min_overflow branch December 3, 2021 14:19
res-life pushed a commit to res-life/spark-rapids that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Get different results when casting from timestamp to string
2 participants