Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bug in ShuffleBufferCatalog.hasActiveShuffle #397

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

abellina
Copy link
Collaborator

Signed-off-by: Alessandro Bellina [email protected]

Fixes a small bug in the ShuffleBufferCatalog where a registered shuffle couldn't be queried again afterwards via hasActiveShuffles. Added a simple test for it.

@abellina abellina added the shuffle things that impact the shuffle plugin label Jul 21, 2020
@jlowe jlowe added this to the Jul 20 - Jul 31 milestone Jul 21, 2020
@jlowe
Copy link
Member

jlowe commented Jul 21, 2020

build

@abellina abellina merged commit 26e69e2 into NVIDIA:branch-0.2 Jul 21, 2020
@abellina abellina deleted the contains_key branch July 21, 2020 18:00
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix small bug in ShuffleBufferCatalog.hasActiveShuffle

Signed-off-by: Alessandro Bellina <[email protected]>

* When unregistering a shuffle, it is no longer active

Signed-off-by: Alessandro Bellina <[email protected]>

* Remove unnecesary imports

Signed-off-by: Alessandro Bellina <[email protected]>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix small bug in ShuffleBufferCatalog.hasActiveShuffle

Signed-off-by: Alessandro Bellina <[email protected]>

* When unregistering a shuffle, it is no longer active

Signed-off-by: Alessandro Bellina <[email protected]>

* Remove unnecesary imports

Signed-off-by: Alessandro Bellina <[email protected]>
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
* fix upload and download job commands, add clone_job

* remove reference to private from fuel
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shuffle things that impact the shuffle plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants