Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for RLike with embedded null in input #3871

Merged
merged 7 commits into from
Nov 2, 2021
Merged

Add integration test for RLike with embedded null in input #3871

merged 7 commits into from
Nov 2, 2021

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Oct 20, 2021 •
edited
Loading

Signed-off-by: Andy Grove [email protected]

Depends on rapidsai/cudf#9470.

This adds an integration test related to #3797 and updates documentation.

@andygrove andygrove added the test Only impacts tests label Oct 20, 2021
@andygrove andygrove added this to the Oct 18 - Oct 29 milestone Oct 20, 2021
@andygrove andygrove self-assigned this Oct 20, 2021
@andygrove andygrove changed the title Add integration test for RLike with embedded null in input WIP: Add integration test for RLike with embedded null in input Oct 20, 2021
@andygrove andygrove marked this pull request as draft October 20, 2021 22:01
@andygrove andygrove changed the title WIP: Add integration test for RLike with embedded null in input Add integration test for RLike with embedded null in input Oct 27, 2021
@andygrove andygrove marked this pull request as ready for review October 27, 2021 15:59
@andygrove andygrove added the documentation Improvements or additions to documentation label Oct 27, 2021
jlowe
jlowe previously approved these changes Nov 1, 2021
View reviewed changes
@jlowe
Copy link
Member

jlowe commented Nov 1, 2021

build

1 similar comment
@jlowe
Copy link
Member

jlowe commented Nov 1, 2021

build

@andygrove
Copy link
Contributor Author

build

@andygrove
Copy link
Contributor Author

test_rlike_null_pattern fails in CI but works locally (against Spark 3.0.1 in both cases).

CI failure:

                   py4j.protocol.Py4JJavaError: An error occurred while calling z:com.nvidia.spark.rapids.ExecutionPlanCaptureCallback.assertDidFallBack.^[[0m
                   : java.lang.AssertionError: assertion failed: Could not find RLike in the GPU plan^[[0m
                   GpuColumnarToRow false^[[0m
                   +- GpuProject [a#336606 gpurlike a^@ AS a RLIKE a^@#336608]^[[0m
                      +- GpuRowToColumnar targetsize(2147483647)^[[0m
                         +- *(1) Scan ExistingRDD[a#336606]^[[0m

@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit 3949168 into NVIDIA:branch-21.12 Nov 2, 2021
@andygrove andygrove deleted the test-rlike-null branch November 2, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@andygrove andygrove

Labels
documentation Improvements or additions to documentation test Only impacts tests
Projects
None yet
Milestone
Nov 1 - Nov 12
Development

Successfully merging this pull request may close these issues.
2 participants
@andygrove @jlowe