Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test utility to compare SQL query results between CPU and GPU #383

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Test utility to compare SQL query results between CPU and GPU #383

merged 2 commits into from
Jul 17, 2020

Conversation

mythrocks
Copy link
Collaborator

Closes #317.

Here is a test utility to run the specified SQL query on CPU and GPU, and verifies that the results are equal.

window_function_test.py demonstrates how this may be used.

@mythrocks mythrocks self-assigned this Jul 17, 2020
@mythrocks mythrocks added the test Only impacts tests label Jul 17, 2020
kuhushukla
kuhushukla reviewed Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@kuhushukla kuhushukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think hash aggregate tests had some occurrences of this as well and it would be good to cover those in this PR as well.

revans2
revans2 previously approved these changes Jul 17, 2020
View reviewed changes
@revans2
Copy link
Collaborator

revans2 commented Jul 17, 2020

build

@mythrocks
Test utility to compare SQL query results between CPU and GPU
97f4175 
Modified hash_aggregate_test.py to use the SQL utility.
@mythrocks
Copy link
Collaborator Author

I think hash aggregate tests had some occurrences of this as well and it would be good to cover those in this PR as well.

I have now changed hash_aggregate_test.py to use this utility, also.

@mythrocks
Copy link
Collaborator Author

build

kuhushukla
kuhushukla approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@kuhushukla kuhushukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u, thank u, thank u!

@mythrocks mythrocks merged commit 6994059 into NVIDIA:branch-0.2 Jul 17, 2020
@mythrocks
Copy link
Collaborator Author

Thank you for the reviews, @revans2, @kuhushukla.

@mythrocks mythrocks deleted the sql-test-wrapper branch July 17, 2020 19:55
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@mythrocks
Test utility to compare SQL query results between CPU and GPU (NVIDIA…
f4abe2e 
…#383)

* Test utility to compare SQL query results between CPU and GPU
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@mythrocks
Test utility to compare SQL query results between CPU and GPU (NVIDIA…
69fd5d5 
…#383)

* Test utility to compare SQL query results between CPU and GPU
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
@IsaacYangSLA
Fix some uncaught yaml loader codes. Replace them with safe_load (NVI…
71c061f 
…DIA#383)
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to 9627091 (NVIDIA#383)
318c60f 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhushukla kuhushukla kuhushukla approved these changes

@revans2 revans2 revans2 left review comments

Assignees

@mythrocks mythrocks

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Write test wrapper to run SQL queries via pyspark
3 participants
@mythrocks @revans2 @kuhushukla