Add audit script to get list of commits from Apache Spark master branch #3791
Conversation
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
|
Most of the file is a copy of the file scripts/audit-spark-3.2.sh. Can we modularize it? |
I had kept it separate as it would be easier to setup jenkins job for separate Spark versions(as we have different commit ids) and also it would be easier to remove the scripts/jenkins job once we stop supporting a particular version. Please let me know if it's okay. |
|
I will update the current script so that it reflects commits from different Spark version. |
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
|
@razajafri @tgravescs I think I have addressed the review comments. PTAL. Have verified this script against the jenkins job and it works fine. |
scripts/audit-spark.sh
Outdated
| git checkout $tag | ||
| git log --oneline HEAD...990bee9c58e -- sql/core/src/main sql/catalyst/src/main > b3.1.1.log | ||
| git log --oneline HEAD...79a6e00b7621bb -- sql/core/src/main sql/catalyst/src/main > previousVersion.log |
There was a problem hiding this comment.
79a6e00b7621bb should this be parameterized as well?
There was a problem hiding this comment.
This is the recent common hash between 2 git branches. Have parameterized this as well now. PTAL.
| basebranch="master" | ||
| tag="branch-3.2" |
There was a problem hiding this comment.
same for these, can/should they be parameterized?
There was a problem hiding this comment.
These are default values. basebranch and tag are parameterized.
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
This PR is to add script to get the list of commits to be audited for Spark-3.3(master) branch.
We already have similar script to get list of commits for Spark-3.2(branch-3.2). The scripts are separated so that it would be easier to setup Jenkins job to get the commits for different branches.