Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change premerge to build all Spark versions #3631

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

tgravescs
Copy link
Collaborator

@tgravescs tgravescs commented Sep 23, 2021

Build all the versions to catch bugs in not updating shims.

@tgravescs tgravescs added the build Related to CI / CD or cleanly building label Sep 23, 2021
@tgravescs tgravescs added this to the Sep 13 - Sep 24 milestone Sep 23, 2021
@tgravescs tgravescs self-assigned this Sep 23, 2021
@tgravescs tgravescs requested a review from revans2 as a code owner September 23, 2021 17:27
@tgravescs
Copy link
Collaborator Author

build

gerashegalov
gerashegalov previously approved these changes Sep 23, 2021
razajafri
razajafri previously approved these changes Sep 23, 2021
jlowe
jlowe previously approved these changes Sep 23, 2021
@tgravescs
Copy link
Collaborator Author

premerge failed due to cdh compile issue, I'll wait til that is fixed and retest this

@tgravescs
Copy link
Collaborator Author

build

env -u SPARK_HOME mvn -U -B $MVN_URM_MIRROR -Dbuildver=312 clean install -Drat.skip=true -DskipTests -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -pl aggregator -am
env -u SPARK_HOME mvn -U -B $MVN_URM_MIRROR -Dbuildver=313 clean install -Drat.skip=true -DskipTests -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -pl aggregator -am
# don't skip tests
env -u SPARK_HOME mvn -U -B $MVN_URM_MIRROR -Dbuildver=320 clean install -Drat.skip=true -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -pl -Dpytest.TEST_TAGS=''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI catches aggregator is missing here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually removed -pl for this one because running tests with it so want to build everything

@tgravescs tgravescs dismissed stale reviews from jlowe, razajafri, and gerashegalov via 996c132 September 23, 2021 23:11
@tgravescs
Copy link
Collaborator Author

build

gerashegalov
gerashegalov previously approved these changes Sep 23, 2021
@tgravescs
Copy link
Collaborator Author

switch the profile back to individual from snapshots. somehow it appears to be downloading jars to the deps directory with timestamp for cdh jar instead of snapshot, so I'll followup with that separately.

@tgravescs
Copy link
Collaborator Author

build

@tgravescs tgravescs merged commit e60d001 into NVIDIA:branch-21.10 Sep 24, 2021
@tgravescs tgravescs deleted the premergeupdates branch September 24, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants