Dedupe proxy rapids shuffle manager byte code #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pidsShuffleManagerByteCode
Spark ShuffleManager causes bytecode discrepancies in the unshimmed area. Inherit it only in the shim-protected code: ``` $ grep ProxyRapidsShuffleInternalManagerBase.class dist/target/binary-diffs/* dist/target/binary-diffs/spark311cdh-spark302.identical:org/apache/spark/sql/rapids/ProxyRapidsShuffleInternalManagerBase.class dist/target/binary-diffs/spark311cdh-spark312.identical:org/apache/spark/sql/rapids/ProxyRapidsShuffleInternalManagerBase.class dist/target/binary-diffs/spark311cdh-spark320.identical:org/apache/spark/sql/rapids/ProxyRapidsShuffleInternalManagerBase.class ``` Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
requested review from
tgravescs and
abellina
and removed request for
tgravescs
revans2
reviewed
Sep 22, 2021
…pidsShuffleManagerByteCode
Signed-off-by: Gera Shegalov <[email protected]>
@revans2 I agree. However, this was a subtle area where I found it safer to make the Proxy to follow the existing implementation in lockstep. I added a shim README to explain the general background. I think we can get rid of some of the intermediate classes. I prefer it to be done on 21.12 branch |
|
build |
pxLi
reviewed
Sep 23, 2021
Signed-off-by: Gera Shegalov <[email protected]>
|
build |
revans2
approved these changes
Sep 23, 2021
| * Trait that makes it easy to check whether we are dealing with the | ||
| * a RAPIDS Shuffle Manager | ||
| * | ||
| * TODO name does not match its function anymore |
There was a problem hiding this comment.
Are you going to fix this TODO?
There was a problem hiding this comment.
I filed #3624 for this.
abellina
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop inheriting ShuffleManaager in base class. Spark ShuffleManager causes bytecode discrepancies in the unshimmed area. Inherit it only in the version-specific code:
Previously, only 3.1+ was bitwise-identical
After the PR, bitwise-identical across all supported 3.x
Other changes:
org.apache.spark.sql.rapids.shims.spark301.RapidsShuffleInternalManagerSigned-off-by: Gera Shegalov [email protected]