Remove shim-specific copies of ParquetCachedBatchSerializer #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
This reverts commit cafaa08. Signed-off-by: Raza Jafri <[email protected]>
|
it looks like the no-buildver-default profile from the pom.xml is missing from the spark313 shim (missed in #3323), well it might not have been needed at that point due to only doing some proof of concept consolidation |
Signed-off-by: Raza Jafri <[email protected]>
razajafri
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
|
This should wait on #3381 and dist jar change |
sameerz
added
the
task
|
@tgravescs is working on #3411 which might be difficult to upmerge, so I think this PR still should wait. |
|
taking this over, going to upmerge and then re-enable tests if everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the shim-specific copies of the ParquetCachedBatchSerializer.
After building with the default profile. This was tested with the v2 version of the serializer against Spark-3.1.1 and Spark-3.1.2 for running test_cache.py and they both were successful.
fixes #3314