Fix AnsiCastOpSuite failures with Spark 3.2 #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <[email protected]>
andygrove
commented
Sep 3, 2021
shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/Spark320Shims.scala
Show resolved
Hide resolved
54 tasks
Signed-off-by: Andy Grove <[email protected]>
Signed-off-by: Andy Grove <[email protected]>
Signed-off-by: Andy Grove <[email protected]>
Signed-off-by: Andy Grove <[email protected]>
54 tasks
revans2
reviewed
Sep 3, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/SparkShims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark30+all/scala/com/nvidia/spark/rapids/shims/v2/Spark30XShims.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Andy Grove <[email protected]>
revans2
previously approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Looks good to me, but I want to be sure that @gerashegalov is also okay with it because he reviewed this too.
54 tasks
revans2
previously approved these changes
Sep 7, 2021
|
build |
gerashegalov
previously approved these changes
Sep 7, 2021
| recurse(plan, predicate, new ListBuffer[SparkPlan]()) | ||
| } | ||
|
|
||
| override def shouldAssertIsOnTheGpu(plan: SparkPlan): Boolean = plan match { |
There was a problem hiding this comment.
I am tempted to suggest trading off type safety for such small auxiliary functions and just do string comparison in the shared code instead of instanceof checks in the future.
|
I am looking into the test failures |
|
build |
|
build |
revans2
reviewed
Sep 10, 2021
|
This PR does not build on Databricks. I will have a fix up later today. |
|
I pushed a fix and this now builds on Databricks 7.3 |
|
build |
revans2
approved these changes
Sep 13, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates an assertion in AnsiCastOpSuite and fixes all 21 test failures when running against Spark 3.2
This partially addresses #3376