Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide private info in Jenkins scripts #330

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Jul 8, 2020

1, Hide urm maven/docker repo address in Jenkins scripts

To build on a local host referring to urm repo, `URM_URL` env is needed along with `-s 
jenkins/settings.xml`, e.g.

    export URM_URL=https://urm.nvidia.com:443/artifactory/sw-spark-maven
    mvn package -s jenkins/settings.xml

2, Only update Jenkins scripts, no source change. No unit tests needed.

3, No Github issue related to the PR.

Hide urm maven/docker repo address in Jenkins scripts

To build on a local host referring to urm repo, `URM_URL` env is needed along with `-s jenkins/settings.xml`, e.g.

        export URM_URL=https://urm.nvidia.com:443/artifactory/sw-spark-maven
        mvn package -s jenkins/settings.xml
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jul 8, 2020

build

@tgravescs
Copy link
Collaborator

so how is ArtifactoryConstants.ARTIFACTORY_NAME picked up during the nightly?

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Jul 8, 2020

so how is ArtifactoryConstants.ARTIFACTORY_NAME picked up during the nightly?

ArtifactoryConstants.ARTIFACTORY_NAME is a var in the Jenkins system, so every Jenkinsfile can read it.

@jlowe jlowe added the build Related to CI / CD or cleanly building label Jul 8, 2020
@NvTimLiu NvTimLiu merged commit 7376c47 into NVIDIA:branch-0.2 Jul 8, 2020
@sameerz sameerz added this to the Jul 6 - Jul 17 milestone Jul 17, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Hide urm maven/docker repo address in Jenkins scripts

To build on a local host referring to urm repo, `URM_URL` env is needed along with `-s jenkins/settings.xml`, e.g.

        export URM_URL=https://urm.nvidia.com:443/artifactory/sw-spark-maven
        mvn package -s jenkins/settings.xml

Co-authored-by: Tim Liu <[email protected]>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Hide urm maven/docker repo address in Jenkins scripts

To build on a local host referring to urm repo, `URM_URL` env is needed along with `-s jenkins/settings.xml`, e.g.

        export URM_URL=https://urm.nvidia.com:443/artifactory/sw-spark-maven
        mvn package -s jenkins/settings.xml

Co-authored-by: Tim Liu <[email protected]>
pxLi pushed a commit to pxLi/spark-rapids that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants