Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support map type in case when expression #3296

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Aug 25, 2021

Support map type in case when expression.
This fixes #3140; This fixes #3139

Signed-off-by: res-life [email protected]

@res-life res-life changed the title Support map type on case when (#3140) Support map type on case when Aug 25, 2021
@res-life
Copy link
Collaborator Author

build

@res-life res-life changed the title Support map type on case when Support map type in case when expression Aug 25, 2021
@firestarman
Copy link
Collaborator

firestarman commented Aug 25, 2021

Looks good to me. However you can also link to the issue #3139 if it has been fixed already.

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@revans2 revans2 merged commit 7da3905 into NVIDIA:branch-21.10 Aug 25, 2021
@sameerz sameerz added the feature request New feature or request label Aug 25, 2021
@sameerz sameerz added this to the Aug 16 - Aug 27 milestone Aug 25, 2021
@res-life res-life deleted the case-when-support-map branch August 26, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support Map type on case when [BUG] case when on some nested types can produce a crash
4 participants