-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for LeftOuter/BuildRight and RightOuter/BuildLeft nested loop joins #3242
Merged
revans2
merged 4 commits into
NVIDIA:branch-21.10
from
jlowe:nested-loop-join-left-right
Aug 20, 2021
Merged
Support for LeftOuter/BuildRight and RightOuter/BuildLeft nested loop joins #3242
revans2
merged 4 commits into
NVIDIA:branch-21.10
from
jlowe:nested-loop-join-left-right
Aug 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… joins Signed-off-by: Jason Lowe <[email protected]>
build |
revans2
reviewed
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, just curious about the TODOs in the code
sql-plugin/src/main/scala/com/nvidia/spark/rapids/AbstractGpuJoinIterator.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuHashJoin.scala
Show resolved
Hide resolved
build |
revans2
previously approved these changes
Aug 19, 2021
Had to resolve a conflict with yesterday's AST API update. |
build |
revans2
approved these changes
Aug 19, 2021
build |
9 tasks
razajafri
pushed a commit
to razajafri/spark-rapids
that referenced
this pull request
Aug 23, 2021
… joins (NVIDIA#3242) Signed-off-by: Jason Lowe <[email protected]> Signed-off-by: Raza Jafri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3111.
This adds GPU support for LeftOuter with BuildRight and RightOuter with BuildLeft broadcast nested loop joins.