Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflict 3122 from branch-21.06 [skip ci] #3124

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Aug 4, 2021

fix merge conflict of #3122
also update changelog script

tgravescs and others added 2 commits August 4, 2021 09:20
* Update spark 301db shim to new ParquetFilter api (NVIDIA#3100)

Signed-off-by: Thomas Graves <[email protected]>

* Fix ParquetFilters issue (NVIDIA#2961)

* Fix ParquetFilters issue

Spark has added datetime rebase mode into constructor of ParquetFilters,
see SPARK-36034, which causes the build failed.

This change is adding getParquetFilters in the shim layers to match
different Spark version.

Signed-off-by: Bobby Wang <[email protected]>

* Fix compiling error

Co-authored-by: Bobby Wang <[email protected]>
@pxLi pxLi added the test Only impacts tests label Aug 4, 2021
@pxLi pxLi requested review from GaryShen2008 and NvTimLiu August 4, 2021 01:37
@pxLi pxLi changed the title Fix merge conflict 3122 Fix merge conflict 3122 [skip ci] Aug 4, 2021
@pxLi pxLi added documentation Improvements or additions to documentation and removed test Only impacts tests labels Aug 4, 2021
@pxLi
Copy link
Collaborator Author

pxLi commented Aug 4, 2021

build

Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pxLi
Copy link
Collaborator Author

pxLi commented Aug 4, 2021

this will merged as a merge commit

@pxLi pxLi merged commit 73500b2 into NVIDIA:branch-21.08 Aug 4, 2021
@pxLi pxLi changed the title Fix merge conflict 3122 [skip ci] Fix merge conflict 3122 from branch-21.06 [skip ci] Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants