Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UCX assertion to show the failed assertion #2922

Merged
merged 3 commits into from
Jul 19, 2021

Conversation

andygrove
Copy link
Contributor

Signed-off-by: Andy Grove [email protected]

I had an error in my setup and got an assertion failed with no additional context. This PR simply shows what the failed assertion was, saving a bit of time in debugging.

Before:

Caused by: java.lang.AssertionError: assertion failed
	at scala.Predef$.assert(Predef.scala:208)
	at org.apache.spark.sql.rapids.GpuShuffleEnv$.setRapidsShuffleManager(GpuShuffleEnv.scala:91)

After:

Caused by: java.lang.AssertionError: assertion failed: com.nvidia.spark.rapids.spark301.RapidsShuffleManager == com.nvidia.spark.rapids.spark311.RapidsShuffleManager
	at scala.Predef$.assert(Predef.scala:223)
	at org.apache.spark.sql.rapids.GpuShuffleEnv$.setRapidsShuffleManager(GpuShuffleEnv.scala:92)

@andygrove andygrove added this to the July 5 - July 16 milestone Jul 13, 2021
@andygrove andygrove self-assigned this Jul 13, 2021
@andygrove andygrove added the ease of use Makes the product simpler to use or configure label Jul 13, 2021
abellina
abellina previously approved these changes Jul 13, 2021
Signed-off-by: Andy Grove <[email protected]>
@jlowe
Copy link
Contributor

jlowe commented Jul 16, 2021

build

@andygrove
Copy link
Contributor Author

Tests against 3.1.3-SNAPSHOT failed with

java.lang.NoSuchMethodError: org.apache.spark.sql.execution.datasources.parquet.ParquetFilters.<init>(Lorg/apache/parquet/schema/MessageType;ZZZZIZ)V
[2021-07-16T20:40:17.896Z] 	at com.nvidia.spark.rapids.GpuParquetFileFilterHandler.filterBlocks(GpuParquetScan.scala:269)
[2021-07-16T20:40:17.896Z] 	at com.nvidia.spark.rapids.GpuParquetMultiFilePartitionReaderFactory.$anonfun$buildBaseColumnarReaderForCoalescing$1(GpuParquetScan.scala:365)

@pxLi
Copy link
Collaborator

pxLi commented Jul 19, 2021

build

@jlowe jlowe merged commit 251dbb2 into NVIDIA:branch-21.08 Jul 19, 2021
@andygrove andygrove deleted the ucx-assertion-message branch November 30, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ease of use Makes the product simpler to use or configure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants