Update dot graph to include stages and remove some duplication #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
revans2
added
the
task
|
build |
1 similar comment
|
build |
|
Something odd happened with the previous CI job. It skipped everything and I don't know why. |
|
@andygrove can you take a look |
andygrove
previously approved these changes
Jun 22, 2021
tgravescs
reviewed
Jun 22, 2021
|
@tgravescs I updated the test and I also added in some more docs to the README to explain how the stages work. |
|
build |
tgravescs
previously approved these changes
Jun 23, 2021
|
build |
andygrove
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a modified version of the code that Apache Spark uses to generate its SQL visualization. I updated it to match the style that we currently are using.
This fixes #2711
This fixes #2712
It does not add in job information it could do it, but it is not that critical.
It is not perfect with how it dedupes stages/etc but it is as good as Apache Spark is, because it reuses the code.
This rips out the compare code, that was not being used, and I plan to work on getting a stage to stage comparison setup next so we can more easily see which stages, in large queries both between the CPU and the GPU, and equivalent. That way I can more quickly see what is showing speedups or not.