Profiling tool - fix reporting contains dataset when sql time 0 #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <[email protected]>
|
build |
gerashegalov
approved these changes
Jun 9, 2021
| @@ -343,6 +343,7 @@ class EventsProcessor(forQualification: Boolean = false) extends Logging { | |||
| None, | |||
| "", | |||
| None, | |||
| false, | |||
There was a problem hiding this comment.
let use named parameters for readability
nartal1
approved these changes
Jun 9, 2021
rongou
pushed a commit
to rongou/spark-rapids
that referenced
this pull request
Jun 9, 2021
…IA#2651) * Fix matching on the dataset Signed-off-by: Thomas Graves <[email protected]> * Add test for contains dataset
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug on profiling side with reporting contains dataset when the sql time was 0. Simply add another field to the table to explicitly set it.