Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload build failure log to Github for external contributors access #2554

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Upload build failure log to Github for external contributors access #2554

merged 1 commit into from
Jun 15, 2021

Conversation

zhanga5
Copy link
Contributor

@zhanga5 zhanga5 commented Jun 2, 2021 •
edited by tgravescs
Loading

Please do not merge this PR as it still need more testings.

The log will be uploaded as one of artifacts on github and can be reached via link of blossom-ci Details in case of build failed

@zhanga5
Copy link
Contributor Author

zhanga5 commented Jun 2, 2021

build

@zhanga5
Copy link
Contributor Author

zhanga5 commented Jun 3, 2021

build

@zhanga5
Copy link
Contributor Author

zhanga5 commented Jun 4, 2021

build

@zhanga5 zhanga5 changed the title Draft: upload build failure log to Github for external contributors access Upload build failure log to Github for external contributors access Jun 4, 2021
@tgravescs
Copy link
Collaborator

could you please add more description. Where exactly do these get uploaded to? Ie how would user see them.

@sameerz sameerz added the build Related to CI / CD or cleanly building label Jun 4, 2021
@zhanga5
Copy link
Contributor Author

zhanga5 commented Jun 5, 2021

could you please add more description. Where exactly do these get uploaded to? Ie how would user see them.

thanks for your comments. The log will be uploaded as one of artifacts on github and can be reached via link of blossom-ci Details in case of build failed

@tgravescs
Copy link
Collaborator

could you please add more description. Where exactly do these get uploaded to? Ie how would user see them.

thanks for your comments. The log will be uploaded as one of artifacts on github and can be reached via link of blossom-ci Details in case of build failed

Note, I meant put it in the PR description at the top. I updated for you.

@zhanga5
Copy link
Contributor Author

zhanga5 commented Jun 10, 2021

build

1 similar comment
@pxLi
Copy link
Collaborator

pxLi commented Jun 10, 2021

build

@zhanga5 zhanga5 merged commit c5f9817 into NVIDIA:branch-21.08 Jun 15, 2021
@zhanga5 zhanga5 deleted the log_upload branch June 15, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@jlowe jlowe Awaiting requested review from jlowe

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhanga5 @tgravescs @pxLi @sameerz