Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove work around for nulls in semi-anti joins #2502

Merged
merged 1 commit into from
May 25, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -623,13 +623,9 @@ trait GpuHashJoin extends GpuExec {
// The 10k is mostly for tests, hopefully no one is setting anything that low in production.
val realTarget = Math.max(targetSize, 10 * 1024)

// Filtering nulls on the build side is a workaround.
// 1) For a performance issue in LeftSemi and LeftAnti joins
// https://github.com/rapidsai/cudf/issues/7300
// 2) As a work around to Struct joins with nullable children
// Filtering nulls on the build side is a workaround for Struct joins with nullable children
// see https://github.com/NVIDIA/spark-rapids/issues/2126 for more info
val builtAnyNullable = (compareNullsEqual || joinType == LeftSemi || joinType == LeftAnti) &&
buildKeys.exists(_.nullable)
val builtAnyNullable = compareNullsEqual && buildKeys.exists(_.nullable)

val nullFiltered = if (builtAnyNullable) {
GpuHashJoin.filterNulls(builtBatch, boundBuildKeys)
Expand Down