Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant collection conversions #2210

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Apr 20, 2021

Contributes to #2109

  • unnecessary toSeq
  • .size on Array or String causes conversion to SeqLike
  • use mnemonic isEmpty/nonEmpty where possible
  • substitute map for unzip

Signed-off-by: Gera Shegalov [email protected]

- unnecessary toSeq
- .size on Array or String causes conversion to SeqLike

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov requested review from jlowe and tgravescs April 20, 2021 22:44
@gerashegalov gerashegalov self-assigned this Apr 20, 2021
@jlowe
Copy link
Member

jlowe commented Apr 20, 2021

build

@gerashegalov gerashegalov merged commit d0964b5 into NVIDIA:branch-0.5 Apr 21, 2021
@gerashegalov gerashegalov deleted the collectionConversions branch April 21, 2021 01:19
@sameerz sameerz added the task Work required that improves the product but is not user facing label Apr 23, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Contributes to NVIDIA#2109 
- unnecessary toSeq
- .size on Array or String causes conversion to SeqLike
- use mnemonic isEmpty/nonEmpty where possible
- substitute map for unzip

Signed-off-by: Gera Shegalov <[email protected]>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Contributes to NVIDIA#2109 
- unnecessary toSeq
- .size on Array or String causes conversion to SeqLike
- use mnemonic isEmpty/nonEmpty where possible
- substitute map for unzip

Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants