-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databricks Build Support #221
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4f961b2
Add a profile to build for Databricks
tgravescs 3874aa5
move dependency to management section for databricks annoation
tgravescs 4fb2cda
Databricks build and deploy scripts
tgravescs d3f73a1
Change the way we match DeserializeToObjectExec because some Spark
tgravescs e6e14e3
Update description on jenkins file
tgravescs 320ff12
cleanup copyrights
tgravescs b171ce5
remove extra databricks exclude
tgravescs 2db2618
more cleanup
tgravescs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
#!/usr/local/env groovy | ||
/* | ||
* Copyright (c) 2020, NVIDIA CORPORATION. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
/** | ||
* | ||
* Jenkinsfile for building rapids-plugin on Databricks | ||
* | ||
*/ | ||
|
||
pipeline { | ||
agent { label 'vanilla' } | ||
|
||
options { | ||
ansiColor('xterm') | ||
timeout(time: 120, unit: 'MINUTES') | ||
buildDiscarder(logRotator(numToKeepStr: '10')) | ||
} | ||
|
||
parameters { | ||
choice(name: 'DEPLOY_TO', choices: ['Urm', 'Local'], | ||
description: 'Where to deploy artifacts to') | ||
string(name: 'REF', defaultValue: 'branch-0.1', description: 'Commit to build') | ||
} | ||
|
||
environment { | ||
JENKINS_ROOT = 'jenkins' | ||
MVN_URM_MIRROR='-s jenkins/settings.xml -P mirror-apache-to-urm' | ||
LIBCUDF_KERNEL_CACHE_PATH='/tmp' | ||
URM_CREDS = credentials("svcngcc_artifactory") | ||
DATABRICKS_TOKEN = credentials("SPARK_DATABRICKS_TOKEN") | ||
} | ||
|
||
triggers { | ||
cron('H 5 * * *') | ||
} | ||
|
||
stages { | ||
stage('Ubuntu16 CUDA10.1') { | ||
agent { | ||
dockerfile { | ||
label 'docker-gpu' | ||
filename 'Dockerfile.ubuntu16' | ||
dir "jenkins" | ||
args '--runtime=nvidia -v ${HOME}/.m2:${HOME}/.m2:rw \ | ||
-v ${HOME}/.zinc:${HOME}/.zinc:rw \ | ||
-v /etc/passwd:/etc/passwd -v /etc/group:/etc/group' | ||
} | ||
} | ||
steps { | ||
script { | ||
sshagent(credentials : ['svcngcc_pubpriv']) { | ||
sh "mvn versions:set -DnewVersion=0.1-databricks-SNAPSHOT && git clean -d -f" | ||
sh "patch -p1 < ./jenkins/databricks/dbimports.patch" | ||
sh "tar -zcvf spark-rapids-ci.tgz * || true" | ||
sh "python3.6 ./jenkins/databricks/run-tests.py -z ./spark-rapids-ci.tgz -t $DATABRICKS_TOKEN -p /home/svcngcc/.ssh/id_rsa -l ./jenkins/databricks/build.sh" | ||
sh "./jenkins/databricks/deploy.sh" | ||
} | ||
} | ||
} | ||
} | ||
stage('cleanup') { | ||
agent { | ||
dockerfile { | ||
label 'docker-gpu' | ||
filename 'Dockerfile.ubuntu16' | ||
dir "jenkins" | ||
args '--runtime=nvidia -v ${HOME}/.m2:${HOME}/.m2:rw \ | ||
-v ${HOME}/.zinc:${HOME}/.zinc:rw \ | ||
-v /etc/passwd:/etc/passwd -v /etc/group:/etc/group' | ||
} | ||
} | ||
steps { | ||
script { | ||
sh "python3.6 ./jenkins/databricks/shutdown.py -t $DATABRICKS_TOKEN" | ||
} | ||
} | ||
} | ||
} // end of stages | ||
post { | ||
always { | ||
script { | ||
if (currentBuild.currentResult == "SUCCESS") { | ||
slack("#rapidsai-spark-cicd", "Success", color: "#33CC33") | ||
} else { | ||
slack("#rapidsai-spark-cicd", "Failed", color: "#FF0000") | ||
} | ||
} | ||
} | ||
} | ||
} // end of pipeline | ||
|
||
void slack(Map params = [:], String channel, String message) { | ||
Map defaultParams = [ | ||
color: "#000000", | ||
baseUrl: "https://nvidia.slack.com/services/hooks/jenkins-ci/", | ||
tokenCredentialId: "slack_token" | ||
] | ||
|
||
params["channel"] = channel | ||
params["message"] = "${BUILD_URL}\n" + message | ||
|
||
slackSend(defaultParams << params) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
#!/bin/bash | ||
# | ||
# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
set -e | ||
|
||
SPARKTGZ=/home/ubuntu/spark-rapids-ci.tgz | ||
if [ "$1" != "" ]; then | ||
SPARKTGZ=$1 | ||
fi | ||
|
||
sudo apt install -y maven | ||
rm -rf spark-rapids | ||
mkdir spark-rapids | ||
tar -zxvf $SPARKTGZ -C spark-rapids | ||
cd spark-rapids | ||
# pull 3.0.0 artifacts and ignore errors then install databricks jars, then build again | ||
mvn clean package || true | ||
M2DIR=/home/ubuntu/.m2/repository | ||
JARDIR=/databricks/jars | ||
SQLJAR=----workspace_spark_3_0--sql--core--core-hive-2.3__hadoop-2.7_2.12_deploy.jar | ||
CATALYSTJAR=----workspace_spark_3_0--sql--catalyst--catalyst-hive-2.3__hadoop-2.7_2.12_deploy.jar | ||
ANNOTJAR=----workspace_spark_3_0--common--tags--tags-hive-2.3__hadoop-2.7_2.12_deploy.jar | ||
COREJAR=----workspace_spark_3_0--core--core-hive-2.3__hadoop-2.7_2.12_deploy.jar | ||
VERSIONJAR=----workspace_spark_3_0--core--libcore_generated_resources.jar | ||
VERSION=3.0.0 | ||
mvn install:install-file \ | ||
-Dmaven.repo.local=$M2DIR \ | ||
-Dfile=$JARDIR/$COREJAR \ | ||
-DgroupId=org.apache.spark \ | ||
-DartifactId=spark-core_2.12 \ | ||
-Dversion=$VERSION \ | ||
-Dpackaging=jar | ||
|
||
mvn install:install-file \ | ||
-Dmaven.repo.local=$M2DIR \ | ||
-Dfile=$JARDIR/$CATALYSTJAR \ | ||
-DgroupId=org.apache.spark \ | ||
-DartifactId=spark-catalyst_2.12 \ | ||
-Dversion=$VERSION \ | ||
-Dpackaging=jar | ||
|
||
mvn install:install-file \ | ||
-Dmaven.repo.local=$M2DIR \ | ||
-Dfile=$JARDIR/$SQLJAR \ | ||
-DgroupId=org.apache.spark \ | ||
-DartifactId=spark-sql_2.12 \ | ||
-Dversion=$VERSION \ | ||
-Dpackaging=jar | ||
|
||
mvn install:install-file \ | ||
-Dmaven.repo.local=$M2DIR \ | ||
-Dfile=$JARDIR/$ANNOTJAR \ | ||
-DgroupId=org.apache.spark \ | ||
-DartifactId=spark-annotation_2.12 \ | ||
-Dversion=$VERSION \ | ||
-Dpackaging=jar | ||
|
||
mvn install:install-file \ | ||
-Dmaven.repo.local=$M2DIR \ | ||
-Dfile=$JARDIR/$VERSIONJAR \ | ||
-DgroupId=org.apache.spark \ | ||
-DartifactId=spark-version_2.12 \ | ||
-Dversion=$VERSION \ | ||
-Dpackaging=jar | ||
|
||
mvn -Pdatabricks clean verify -DskipTests | ||
|
||
# copy so we pick up new built jar | ||
sudo cp dist/target/rapids-4-spark_2.12-*-SNAPSHOT.jar /databricks/jars/rapids-4-spark_2.12-0.1-SNAPSHOT-ci.jar | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same hardcoded version issue here. |
||
|
||
# tests | ||
export PATH=/databricks/conda/envs/databricks-ml-gpu/bin:/databricks/conda/condabin:$PATH | ||
sudo /databricks/conda/envs/databricks-ml-gpu/bin/pip install pytest sre_yield | ||
cd /home/ubuntu/spark-rapids/integration_tests | ||
export SPARK_HOME=/databricks/spark | ||
export PYTHONPATH=$SPARK_HOME/python:$SPARK_HOME/python/pyspark/:$SPARK_HOME/python/lib/py4j-0.10.9-src.zip | ||
sudo ln -s /databricks/jars/ $SPARK_HOME/jars || true | ||
sudo chmod 777 /databricks/data/logs/ | ||
sudo chmod 777 /databricks/data/logs/* | ||
echo { \"port\":\"15002\" } > ~/.databricks-connect | ||
$SPARK_HOME/bin/spark-submit ./runtests.py 2>&1 | tee out | ||
|
||
cd /home/ubuntu | ||
tar -zcvf spark-rapids-built.tgz spark-rapids |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuHashJoin.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuHashJoin.scala | ||
index b1599e6..b432fe0 100644 | ||
--- a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuHashJoin.scala | ||
+++ b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuHashJoin.scala | ||
@@ -18,8 +18,9 @@ package com.nvidia.spark.rapids | ||
import ai.rapids.cudf.{NvtxColor, Table} | ||
|
||
import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression} | ||
+import org.apache.spark.sql.catalyst.optimizer.{BuildLeft, BuildRight} | ||
import org.apache.spark.sql.catalyst.plans.{Inner, JoinType, LeftAnti, LeftOuter, LeftSemi} | ||
-import org.apache.spark.sql.execution.joins.{BuildLeft, BuildRight, HashJoin} | ||
+import org.apache.spark.sql.execution.joins.HashJoin | ||
import org.apache.spark.sql.execution.metric.SQLMetric | ||
import org.apache.spark.sql.vectorized.{ColumnarBatch, ColumnVector} | ||
|
||
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuShuffledHashJoinExec.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuShuffledHashJoinExec.scala | ||
index 6de4a95..90fb3e7 100644 | ||
--- a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuShuffledHashJoinExec.scala | ||
+++ b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuShuffledHashJoinExec.scala | ||
@@ -21,10 +21,11 @@ import com.nvidia.spark.rapids.GpuMetricNames._ | ||
import org.apache.spark.TaskContext | ||
import org.apache.spark.rdd.RDD | ||
import org.apache.spark.sql.catalyst.InternalRow | ||
+import org.apache.spark.sql.catalyst.optimizer.{BuildLeft, BuildRight, BuildSide} | ||
import org.apache.spark.sql.catalyst.plans.JoinType | ||
import org.apache.spark.sql.catalyst.plans.physical.{Distribution, HashClusteredDistribution} | ||
import org.apache.spark.sql.execution.{BinaryExecNode, SparkPlan} | ||
-import org.apache.spark.sql.execution.joins.{BuildLeft, BuildRight, BuildSide, ShuffledHashJoinExec} | ||
+import org.apache.spark.sql.execution.joins.ShuffledHashJoinExec | ||
import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics} | ||
import org.apache.spark.sql.vectorized.ColumnarBatch | ||
|
||
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSortMergeJoinExec.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSortMergeJoinExec.scala | ||
index c493508..3e24a2d 100644 | ||
--- a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSortMergeJoinExec.scala | ||
+++ b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSortMergeJoinExec.scala | ||
@@ -17,8 +17,9 @@ | ||
package com.nvidia.spark.rapids | ||
|
||
import org.apache.spark.internal.Logging | ||
+import org.apache.spark.sql.catalyst.optimizer.BuildRight | ||
import org.apache.spark.sql.execution.SortExec | ||
-import org.apache.spark.sql.execution.joins.{BuildRight, SortMergeJoinExec} | ||
+import org.apache.spark.sql.execution.joins.SortMergeJoinExec | ||
|
||
class GpuSortMergeJoinMeta( | ||
join: SortMergeJoinExec, | ||
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsMeta.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsMeta.scala | ||
index 088b66b..b7f267f 100644 | ||
--- a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsMeta.scala | ||
+++ b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsMeta.scala | ||
@@ -22,12 +22,13 @@ import com.nvidia.spark.rapids.GpuOverrides.isStringLit | ||
|
||
import org.apache.spark.sql.catalyst.expressions.{BinaryExpression, ComplexTypeMergingExpression, Expression, String2TrimExpression, TernaryExpression, UnaryExpression} | ||
import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateFunction | ||
+import org.apache.spark.sql.catalyst.optimizer.{BuildLeft, BuildRight} | ||
import org.apache.spark.sql.catalyst.plans.physical.Partitioning | ||
import org.apache.spark.sql.connector.read.Scan | ||
import org.apache.spark.sql.execution.SparkPlan | ||
import org.apache.spark.sql.execution.command.DataWritingCommand | ||
import org.apache.spark.sql.execution.exchange.ShuffleExchangeExec | ||
-import org.apache.spark.sql.execution.joins.{BroadcastHashJoinExec, BuildLeft, BuildRight, ShuffledHashJoinExec, SortMergeJoinExec} | ||
+import org.apache.spark.sql.execution.joins.{BroadcastHashJoinExec, ShuffledHashJoinExec, SortMergeJoinExec} | ||
import org.apache.spark.sql.types.{CalendarIntervalType, DataType, DataTypes, StringType} | ||
|
||
trait ConfKeysAndIncompat { | ||
diff --git a/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastHashJoinExec.scala b/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastHashJoinExec.scala | ||
index dc12bbe..a07add3 100644 | ||
--- a/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastHashJoinExec.scala | ||
+++ b/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuBroadcastHashJoinExec.scala | ||
@@ -21,6 +21,7 @@ import com.nvidia.spark.rapids.GpuMetricNames._ | ||
|
||
import org.apache.spark.rdd.RDD | ||
import org.apache.spark.sql.catalyst.InternalRow | ||
+import org.apache.spark.sql.catalyst.optimizer.{BuildLeft, BuildRight, BuildSide} | ||
import org.apache.spark.sql.catalyst.plans.JoinType | ||
import org.apache.spark.sql.catalyst.plans.physical.{BroadcastDistribution, Distribution, UnspecifiedDistribution} | ||
import org.apache.spark.sql.execution.{BinaryExecNode, SparkPlan} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#!/bin/bash | ||
# | ||
# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
set -e | ||
rm -rf deploy | ||
mkdir -p deploy | ||
cd deploy | ||
tar -zxvf ../spark-rapids-built.tgz | ||
cd spark-rapids | ||
echo "Maven mirror is $MVN_URM_MIRROR" | ||
SERVER_ID='snapshots' | ||
SERVER_URL='https://urm.nvidia.com:443/artifactory/sw-spark-maven-local' | ||
FPATH=./dist/target/rapids-4-spark_2.12-0.1-databricks-SNAPSHOT.jar | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same hardcoded version issue here. |
||
mvn -B deploy:deploy-file $MVN_URM_MIRROR -Durl=$SERVER_URL -DrepositoryId=$SERVER_ID \ | ||
-Dfile=$FPATH -DpomFile=dist/pom.xml |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a jenkins variable or somehow computed from the version set in the pom? Otherwise we need to manually remember to update it when we move versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I agree, that is in the followup issue to make things more parameterized. I can change this here if it makes releasing easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK as long as whoever is doing the release knows to update these three places. Assuming we're doing the release as a PR against master, I think we can manually check it for this first release before merging to master and fix it in the followup #224