Fix unknown column name error when filtering ORC file with no names #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
This will need to be upmerged with #2005 before the CI build will pass. |
|
build |
tgravescs
approved these changes
Mar 24, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…VIDIA#2007) Signed-off-by: Jason Lowe <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…VIDIA#2007) Signed-off-by: Jason Lowe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidsai/cudf#7624 recently exposed an issue in the plugin when handling an ORC file with no column names. The plugin was filtering the stripes based on the columns being referenced but then asking for all columns in the original file schema. After the recent cudf change, that caused an "Unknown column" exception to be thrown.
This updates the code to filter the requested columns to the referenced columns when dealing with a file that has no column names. The existing no-column-name ORC test now passes with this change, so no new test was added.