GpuArrowColumnarBatchBuilder retains the references of ArrowBuf until HostToGpuCoalesceIterator put them into device #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HostToGpuCoalesceIterator put them into device Signed-off-by: Dooyoung Hwang <[email protected]>
Dooyoung-Hwang
force-pushed
the
referencemanager-test
branch
from
7bbb348 to
cbbef78
Compare
|
build |
tgravescs
previously approved these changes
Mar 5, 2021
… releases ArrowBuf's reference Signed-off-by: Dooyoung Hwang <[email protected]>
|
build |
tgravescs
approved these changes
Mar 8, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
… HostToGpuCoalesceIterator put them into device (NVIDIA#1882) * GpuArrowColumnarBatchBuilder retains the references of ArrowBuf until HostToGpuCoalesceIterator put them into device Signed-off-by: Dooyoung Hwang <[email protected]> * Add a testSuite to make sure GpuArrowColumnarBatchBuilder retains and releases ArrowBuf's reference Signed-off-by: Dooyoung Hwang <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
… HostToGpuCoalesceIterator put them into device (NVIDIA#1882) * GpuArrowColumnarBatchBuilder retains the references of ArrowBuf until HostToGpuCoalesceIterator put them into device Signed-off-by: Dooyoung Hwang <[email protected]> * Add a testSuite to make sure GpuArrowColumnarBatchBuilder retains and releases ArrowBuf's reference Signed-off-by: Dooyoung Hwang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GpuArrowColumnarBatchBuilder gets the ByteBuffer address directly from the ArrowBuf in host ColumnVector. Thus, when the provider of host ColumnVector such as custom data-source closes the ArrowBuf, the ByteBuffer memory area stored in GpuArrowColumnarBatchBuilder becomes invalid. In order to prevent the ByteBuffer memory from being deallocated, GpuArrowColumnarBatchBuilder obtains not only the ByteBuffer address but ReferenceManager from ArrowBuf and retains the ReferenceManager until it copies the ArrowBuf into device.
Signed-off-by: Dooyoung Hwang [email protected]