Allow structs and arrays to pass through for Shuffle and Sort #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuhu Shukla <[email protected]>
…into shuffle_structs
revans2
reviewed
Jan 8, 2021
| @@ -772,6 +772,7 @@ def gen_scalars_for_sql(data_gen, count, seed=0, force_no_nulls=False): | |||
| boolean_gens = [boolean_gen] | |||
|
|
|||
| single_level_array_gens = [ArrayGen(sub_gen) for sub_gen in all_basic_gens + decimal_gens + [null_gen]] | |||
| single_level_array_gens_non_decimal = [ArrayGen(sub_gen) for sub_gen in all_basic_gens + [null_gen]] | |||
There was a problem hiding this comment.
I saw some analysis exception with legacy setting for negative scale when trying to sort arrays with decimal type which I am not fully aware on where we stand in terms of support so I excluded those in that particular test.
I will check it out further
sameerz
added
the
task
revans2
changed the title
Signed-off-by: Kuhu Shukla <[email protected]>
|
build |
revans2
previously approved these changes
Jan 12, 2021
…into shuffle_structs
revans2
previously approved these changes
Jan 12, 2021
Signed-off-by: Kuhu Shukla <[email protected]>
|
build |
revans2
approved these changes
Jan 12, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…#1477) Signed-off-by: Kuhu Shukla <[email protected]> Co-authored-by: Kuhu Shukla <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…#1477) Signed-off-by: Kuhu Shukla <[email protected]> Co-authored-by: Kuhu Shukla <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…#1477) Signed-off-by: Robert (Bobby) Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows structs and arrays for shuffle and sort for pass through as i/p and o/p. The change is fairly simple so I am not sure if more is expected from this change or if I missed anything else. Please guide as needed. I saw some analysis exception with legacy setting for negative scale when trying to sort arrays with decimal type which I am not fully aware on where we stand in terms of support so I excluded those in that particular test.