Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for kudo write metrics #11784

Merged
merged 11 commits into from
Dec 6, 2024
Merged

Add support for kudo write metrics #11784

merged 11 commits into from
Dec 6, 2024

Conversation

liurenjie1024
Copy link
Collaborator

@liurenjie1024 liurenjie1024 commented Nov 27, 2024 •
edited
Loading

This pr address two things:

  1. Refactor metrics in gpu exchange to use constants rather string literals.
  2. Add support for kudo write metrics. This part relys on Add write metrics for kudo. spark-rapids-jni#2630 to be merged.

@liurenjie1024 liurenjie1024 mentioned this pull request Nov 27, 2024
Merged
@liurenjie1024
Refactor
7fd3ed9 
Signed-off-by: liurenjie1024 <[email protected]>
@liurenjie1024 liurenjie1024 changed the base branch from branch-24.12 to branch-25.02 November 27, 2024 06:11
@liurenjie1024
Copy link
Collaborator Author

build

@liurenjie1024
Copy link
Collaborator Author

build

@liurenjie1024
Copy link
Collaborator Author

build

@liurenjie1024
Copy link
Collaborator Author

build

revans2
revans2 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but I also want to hear from Jason if he has more concerns

@liurenjie1024 liurenjie1024 merged commit 30c4ddb into NVIDIA:branch-25.02 Dec 6, 2024
49 of 50 checks passed
@liurenjie1024 liurenjie1024 deleted the ray/kudo-writer-metrics branch December 6, 2024 01:29
@sameerz sameerz added performance A performance related task/issue task Work required that improves the product but is not user facing labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

@abellina abellina Awaiting requested review from abellina

Assignees
No one assigned
Labels
performance A performance related task/issue task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liurenjie1024 @jlowe @revans2 @sameerz