Add in support for months_between #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
jlowe
reviewed
Nov 20, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
build |
jlowe
approved these changes
Nov 20, 2024
|
I ran some local benchmarks to see the performance improvement An a6000 GPU can complete this with 16 CPU cores in about 16 seconds (after it warms up) Threadripper PRO 5975WX 32-Cores finishes in about 325 seconds when run with all 32 cores (no hyperthreading). That is about a 20x speedup. |
gerashegalov
approved these changes
Nov 20, 2024
| Seq(ParamCheck("timestamp1", TypeSig.TIMESTAMP, TypeSig.TIMESTAMP), | ||
| ParamCheck("timestamp2", TypeSig.TIMESTAMP, TypeSig.TIMESTAMP), | ||
| ParamCheck("round", TypeSig.lit(TypeEnum.BOOLEAN), TypeSig.BOOLEAN))), | ||
| (a, conf, p, r) => new MonthsBetweenExprMeta(a, conf, p, r) |
There was a problem hiding this comment.
nit: If there are more comments to address it would be nice to follow the pattern like GpuMapFromArraysMeta
to avoid manual parameter passing
| override def convertToGpu(): GpuExpression = { | ||
| val gpuChildren = childExprs.map(_.convertToGpu()) | ||
| assert(gpuChildren.length == 3) | ||
| GpuMonthsBetween(gpuChildren(0), gpuChildren(1), gpuChildren(2), expr.timeZoneId) |
There was a problem hiding this comment.
nit: either unpack or use named params for readability
Suggested change
| GpuMonthsBetween(gpuChildren(0), gpuChildren(1), gpuChildren(2), expr.timeZoneId) | |
| val Seq(ts1, ts2, roundOff) = gpuChildren | |
| GpuMonthsBetween(ts1, ts2, roundOff, expr.timeZoneId) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11709
The code is a little complicated, mostly because the Spark code is doing some kind of complex things.
I think that there are some more optimizations that we could do to reduce memory and improve performance, but I wanted to get something working out the door sooner, and then we can look at improving it later.