Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for repeated JSON columns/keys #11362

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Aug 19, 2024

This contributes to #10491

This adds in tests for repeated columns and it found a lot of problems. #11361

But this is a rather odd corner case and because Spark is self inconsistent I think it is something we can keep as a lower priority for fixing.

Signed-off-by: Robert (Bobby) Evans <[email protected]>
@revans2 revans2 mentioned this pull request Aug 19, 2024
41 tasks
@revans2
Copy link
Collaborator Author

revans2 commented Aug 19, 2024

build

@revans2
Copy link
Collaborator Author

revans2 commented Aug 19, 2024

The 4.0.0 failure is #11350 I am working on a fix for that too.

@revans2 revans2 merged commit 2495b72 into NVIDIA:branch-24.10 Aug 19, 2024
43 of 44 checks passed
@revans2 revans2 deleted the repeated_column_json_test branch August 19, 2024 19:10
@sameerz sameerz added the test Only impacts tests label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants