Make JSON parsing common between JsonToStructs and ScanJson #10542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
…into make_json_common
|
build |
sameerz
added
the
task
andygrove
previously approved these changes
Mar 7, 2024
|
build |
1 similar comment
|
build |
|
build |
|
@andygrove could you please take another look? I had gotten some schema mixed up that fixed things for JSON, but ended up breaking CSV. That should be fixed now. |
andygrove
approved these changes
Mar 10, 2024
|
This also fixed #4647 |
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10456
This fixes #10467
This fixes #10469
This fixes #10494
This fixes #9588
This fixes #4779
This fixes #10470
This fixes #10460
This fixes #10468
The fixes are mostly from combining fixes that were in ScanJson with fixes that were in JsonToStructs, which removed a lot of corner cases where one had fixed some things and the other had fixed others.
Sadly it did not fix the date/timestamp parsing. The Date/Timestamp parsing is based off of ScanJson, which was more liberal in many areas compared to
from_json, but does not support reading numbers as dates/timestamps likefrom_jsonpartially did. It caused a number of tests infrom_jsonto start failing partly because it is not falling back in cases that ScanJson has problems.As a part of this it also added in some nested type support for ScanJson with tests added from #10325
With this we also have adopted the configs
spark.rapids.sql.json.read.float.enabled,spark.rapids.sql.json.read.double.enabled, andspark.rapids.sql.json.read.decimal.enabledforfrom_json.