Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minValue overflow check in ORC double-to-timestamp cast #10497

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add minValue overflow check in ORC double-to-timestamp cast #10497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3860fc
Add minValue overflow check in ORC double-to-timestamp cast
gerashegalov Feb 25, 2024
3bfdf01
cleanup
gerashegalov Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOrcScan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2023, NVIDIA CORPORATION.
* Copyright (c) 2019-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -402,13 +402,15 @@ object GpuOrcScan {
// In this step, ORC casting of CPU throw an exception rather than replace such values with
// null. We followed the CPU code here.
withResource(milliseconds) { _ =>
// Test whether if there is long-overflow
// If milliSeconds.max() * 1000 > LONG_MAX, then 'Math.multiplyExact' will
// throw an exception (as CPU code does).
// Test whether if there is long-overflow towards positive and negative infinity
withResource(milliseconds.max()) { maxValue =>
if (maxValue.isValid) {
testLongMultiplicationOverflow(maxValue.getDouble.toLong,
DateTimeConstants.MICROS_PER_MILLIS)
withResource(milliseconds.min()) { minValue =>
Seq(maxValue, minValue).foreach { extremum =>
if (extremum.isValid) {
testLongMultiplicationOverflow(extremum.getDouble.toLong,
DateTimeConstants.MICROS_PER_MILLIS)
}
}
}
}
withResource(Scalar.fromDouble(DateTimeConstants.MICROS_PER_MILLIS)) { thousand =>
Expand Down Expand Up @@ -486,7 +488,7 @@ object GpuOrcScan {
* In Math.multiplyExact, if there is an integer-overflow, then it will throw an
* ArithmeticException.
*/
def testLongMultiplicationOverflow(a: Long, b: Long) = {
private def testLongMultiplicationOverflow(a: Long, b: Long) = {
Math.multiplyExact(a, b)
}

Expand Down
Loading