Update to libcudf unsigned sum aggregation types change #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
build |
revans2
approved these changes
Jan 24, 2024
revans2
added a commit
to revans2/spark-rapids
that referenced
this pull request
Jan 30, 2024
…IA#10267)" This reverts commit 3bb2f6c. Signed-off-by: Robert (Bobby) Evans <[email protected]>
revans2
added a commit
that referenced
this pull request
Jan 30, 2024
…)" (#10331) This reverts commit 3bb2f6c. Signed-off-by: Robert (Bobby) Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10262. Fixes #10264. This updates the plugin to adapt to the changes in libcudf by rapidsai/cudf#14679 regarding the output types of aggregation sums on unsigned input types. Previously unsigned input types produced signed output types, but now they produce unsigned output types.