Prevent a degenerative join in test_dpp_reuse_broadcast_exchange [databricks] #10168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apture the parts of the plan desired in test_dpp_reuse_broadcast_exchange Signed-off-by: Navin Kumar <[email protected]>
|
build |
NVnavkumar
changed the title
jlowe
reviewed
Jan 9, 2024
…ensure uniformity of values so that the union doesn't result in a degenerative join Signed-off-by: Navin Kumar <[email protected]>
|
build |
jlowe
reviewed
Jan 9, 2024
Signed-off-by: Navin Kumar <[email protected]>
jlowe
reviewed
Jan 9, 2024
…ot be degenerative Signed-off-by: Navin Kumar <[email protected]>
jlowe
reviewed
Jan 9, 2024
| if isinstance(child, list): | ||
| super().__init__(data_type, nullable=False) | ||
| self.nullable = nullable | ||
| self._length = len(child) |
There was a problem hiding this comment.
Should assert if length is specified or try to honor it (e.g.: allow it if it's less than the length of the list).
Signed-off-by: Navin Kumar <[email protected]>
jlowe
reviewed
Jan 9, 2024
Signed-off-by: Navin Kumar <[email protected]>
Signed-off-by: Navin Kumar <[email protected]>
Signed-off-by: Navin Kumar <[email protected]>
jlowe
approved these changes
Jan 9, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10147
This ensures that dim table here produces only positive values in the
valuecolumn, so that the filter included in the join does not result in a degenerative join. There is an existingtest_dpp_empty_relationwhich should be testing the scenario that involves DPP+AQE with empty relations from degenerative joins.