Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for version range directories from pom #7847

Closed
gerashegalov opened this issue Mar 6, 2023 · 1 comment · Fixed by #7965
Closed

Remove support for version range directories from pom #7847

gerashegalov opened this issue Mar 6, 2023 · 1 comment · Fixed by #7965
Assignees
@gerashegalov
Labels
build Related to CI / CD or cleanly building

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Mar 6, 2023 •
edited
Loading

Once the project build using the simplified shim directory structure #7487 proves stable, delete build definitions supporting deprecated version range directories.

Look for sparkXYZ.sources and sparkXYZ.test.sources
@gerashegalov gerashegalov added the build Related to CI / CD or cleanly building label Mar 6, 2023
@gerashegalov gerashegalov self-assigned this Mar 28, 2023
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue Mar 28, 2023
@gerashegalov
Remove stale references to the pre-shimplify dirs
c16b325 
Closes NVIDIA#7847

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov mentioned this issue Mar 28, 2023
Merged
gerashegalov added a commit that referenced this issue Mar 29, 2023
@gerashegalov
Remove stale references to the pre-shimplify dirs (#7965)
7a8a5c1 
Closes #7847

Tesing:

- premerge 
- `./build/buldall`
- `mvn -B generate-sources -Dshimplify=true -Dshimplify.move=true -Dshimplify.remove.shim=311`
- `mvn -B generate-sources  -Dshimplify=true -Dshimplify.add.base=323 -Dshimplify.add.shim=324`

Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov
Copy link
Collaborator Author

Fixed by #7965

@gerashegalov gerashegalov linked a pull request Mar 31, 2023 that will close this issue
Remove stale references to the pre-shimplify dirs [databricks] #7965
Merged
abellina pushed a commit to abellina/spark-rapids that referenced this issue Apr 14, 2023
@gerashegalov @abellina
Remove stale references to the pre-shimplify dirs (NVIDIA#7965)
e06dee1 
Closes NVIDIA#7847

Tesing:

- premerge 
- `./build/buldall`
- `mvn -B generate-sources -Dshimplify=true -Dshimplify.move=true -Dshimplify.remove.shim=311`
- `mvn -B generate-sources  -Dshimplify=true -Dshimplify.add.base=323 -Dshimplify.add.shim=324`

Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stale references to the pre-shimplify dirs [databricks] gerashegalov/spark-rapids
1 participant
@gerashegalov