Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add support for regular expressions containing \s and \S #4528

Closed
andygrove opened this issue Jan 13, 2022 · 0 comments · Fixed by #5089
Closed

[FEA] Add support for regular expressions containing \s and \S #4528

andygrove opened this issue Jan 13, 2022 · 0 comments · Fixed by #5089
Assignees
@sperlingxx
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We do not currently support \s or \S in regular expression patterns and fall back to CPU.

\s | A whitespace character: [ \t\n\x0B\f\r]
\S | A non-whitespace character: [^\s]

Describe the solution you'd like
Add support for these expressions.

We have a choice of passing these to cuDF (we need to check if cuDF has the same interpretation of these) or we can transpile to the specific character classes.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 13, 2022
@andygrove andygrove mentioned this issue Jan 13, 2022
Open
61 tasks
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 18, 2022
@sperlingxx sperlingxx self-assigned this Mar 25, 2022
@sperlingxx sperlingxx mentioned this issue Mar 30, 2022
Merged
sperlingxx added a commit that referenced this issue Apr 2, 2022
@sperlingxx
Support regular expressions containing \s and \S (#5089)
17984c0 
Closes #4528

Signed-off-by: sperlingxx [email protected]

Support regular expressions which contain \s and \S through transpiling `\s` to `[ \f\t\r\n\\x0b]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable regular expressions containing \s and \S sperlingxx/spark-rapids
3 participants
@andygrove @sperlingxx @sameerz