Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Usage of Class.forName without specifying a classloader #3710

Closed
gerashegalov opened this issue Sep 29, 2021 · 0 comments · Fixed by #3726
Closed

[BUG] Usage of Class.forName without specifying a classloader #3710

gerashegalov opened this issue Sep 29, 2021 · 0 comments · Fixed by #3726
Assignees
@gerashegalov
Labels
bug Something isn't working
Milestone
Sep 27 - Oct 1

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Sep 29, 2021 •
edited
Loading

Describe the bug
There are instances of Class.forName usage throughout the plugin, some of which don't specify the classloader.

spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostColumnarToGpu.scala

Line 43 in d2051d1

val classObj = Class.forName(className)

Steps/Code to reproduce bug
grep source code

Expected behavior
We should route all these invocations through the ShimLoader. Even if we decide not to do this, we should consistently use the Thread context classloader.

Environment details (please complete the following information)
local

Additional context
#3658
@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 29, 2021
@gerashegalov gerashegalov self-assigned this Sep 30, 2021
@gerashegalov gerashegalov removed the ? - Needs Triage Need team to review and classify label Sep 30, 2021
@gerashegalov gerashegalov mentioned this issue Sep 30, 2021
Merged
@gerashegalov gerashegalov linked a pull request Sep 30, 2021 that will close this issue
Replace Class.forName with ShimLoader.loadClass #3726
Merged
gerashegalov added a commit that referenced this issue Oct 1, 2021
@gerashegalov
Replace Class.forName with ShimLoader.loadClass (#3726)
f0879df 
Most calls use Bootstrap classloader and may create copies for classes loaded via Shim and context classloaders. Fixes #3710 

Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working
Projects
None yet
Milestone
Sep 27 - Oct 1
Development

Successfully merging a pull request may close this issue.

Replace Class.forName with ShimLoader.loadClass gerashegalov/spark-rapids
1 participant
@gerashegalov