Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NullPointerException in SLF4J on startup #3187

Closed
jlowe opened this issue Aug 10, 2021 · 1 comment · Fixed by #3188
Closed

[BUG] NullPointerException in SLF4J on startup #3187

jlowe opened this issue Aug 10, 2021 · 1 comment · Fixed by #3188
Assignees
@gerashegalov
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Milestone
Aug 2 - Aug 13

Comments

@jlowe
Copy link
Contributor

jlowe commented Aug 10, 2021

In #3166 a problem was reported where an NPE could occur in SLF4J on startup:

Failed to instantiate SLF4J LoggerFactory
Reported exception:
java.lang.NullPointerException
at org.slf4j.LoggerFactory.reportActualBinding(LoggerFactory.java:349)

The RAPIDS Accelerator jar is shipping SLF4J classes which probably shouldn't be the case.
@jlowe jlowe added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Aug 10, 2021
@jlowe jlowe mentioned this issue Aug 10, 2021
Closed
@gerashegalov gerashegalov mentioned this issue Aug 10, 2021
Merged
gerashegalov added a commit that referenced this issue Aug 11, 2021
@gerashegalov
Exclude slf4j classes from the spark-rapids jar (#3188)
95e3add 
Exlcluding org.slf4j from the main plugin artifact, closes #3187

Signed-off-by: Gera Shegalov [email protected]
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 12, 2021
@sameerz sameerz added this to the Aug 2 - Aug 13 milestone Aug 12, 2021
@Niharikadutta
Copy link

Thanks @gerashegalov for this PR, the solution worked in resolving the NPE error in slf4j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Aug 2 - Aug 13
Development

Successfully merging a pull request may close this issue.

Exclude slf4j classes from the spark-rapids jar gerashegalov/spark-rapids
4 participants
@jlowe @gerashegalov @sameerz @Niharikadutta