Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Full Outer Join does not work on nullable keys #280

Closed
revans2 opened this issue Jun 24, 2020 · 0 comments · Fixed by #349
Closed

[BUG] Full Outer Join does not work on nullable keys #280

revans2 opened this issue Jun 24, 2020 · 0 comments · Fixed by #349
Assignees
@revans2
Labels
bug Something isn't working SQL part of the SQL/Dataframe plugin
Milestone
Jul 6 - Jul 17

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 24, 2020

Describe the bug
rapidsai/cudf#5563 was filed to allow both SQL and pandas comparisons of nulls on inner joins. Once that goes in we need to adapt our code to use the proper API so we get the proper join.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 24, 2020
@revans2 revans2 mentioned this issue Jun 24, 2020
Merged
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jun 29, 2020
@revans2 revans2 self-assigned this Jul 13, 2020
@revans2 revans2 added this to the Jul 6 - Jul 17 milestone Jul 13, 2020
@revans2 revans2 mentioned this issue Jul 13, 2020
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Merge pull request NVIDIA#280 from NVIDIA/bot-auto-merge-branch-22.06
dbe8263 
[auto-merge] bot-auto-merge-branch-22.06 to branch-22.08 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
Jul 6 - Jul 17
Development

Successfully merging a pull request may close this issue.

Updated join code to treat null equality properly revans2/spark-rapids
2 participants
@revans2 @sameerz