Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Better corner case testing for casting #1764

Open
revans2 opened this issue Feb 18, 2021 · 1 comment
Open

[FEA] Better corner case testing for casting #1764

revans2 opened this issue Feb 18, 2021 · 1 comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf task Work required that improves the product but is not user facing test Only impacts tests

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 18, 2021

From rapidsai/cudf#5225 it is obvious that there are some corner cases that cause issues with float/double tests. Some of these are being fixed as a part of rapidsai/cudf#7410 but our tests are really inadequate despite fuzzing. Really the issue is that we are only testing with 100 values and that the values themselves will never produce invalid values that overflow. They also will never in practice hit a Double.MaxValue or Double.MinValue. It would be nice to have some special tests to augment these.

@revans2 revans2 added ? - Needs Triage Need team to review and classify test Only impacts tests task Work required that improves the product but is not user facing labels Feb 18, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 23, 2021
@sameerz
Copy link
Collaborator

sameerz commented Feb 23, 2021

Will leave open until rapidsai/cudf#7410 issue is fixed so we can add the remaining test cases.

@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf task Work required that improves the product but is not user facing test Only impacts tests
Projects
None yet
Development

No branches or pull requests

2 participants